Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make describe method work on other people's tables #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make describe method work on other people's tables #15

wants to merge 2 commits into from

Conversation

joezuntz
Copy link
Contributor

Fixes issue #14 which I opened! With this you can do, e.g.:
import desdb
conn=desdb.Connection()
conn.describle("joezuntz.im3shape_v7_r")

and it will work as expected. The old mode will still work too.

@esheldon
Copy link
Owner

Hi Joe, thanks for the patch.

I have a couple of comments

  • I recall that all_tab_cols didn't always work, which is why I switched to fgetmetadata. Have you seen this work for all tables?
  • doesn't that set owner to yourself when doing a describe on a global table, such as coadd_objects? I think when there is no dot in the table name, the owner clause should not be present at all

@joezuntz
Copy link
Contributor Author

Hi Erin,

Definitely good point on the second one - I didn’t actually know there were global tables! For example I can list the contents of coadd_objects but can’t see it on any kind of list of tables I can generate. Any ideas?

I think this may be related to your first point, too - there may be tables I don’t know exist to test it on. I’ll change it to leave it without a username by default, definitely.

Joe

On 30 Oct 2014, at 14:04, Erin Sheldon [email protected] wrote:

Hi Joe, thanks for the patch.

I have a couple of comments

I recall that all_tab_cols didn't always work, which is why I switched to fgetmetadata. Have you seen this work for all tables?
doesn't that set owner to yourself when doing a describe on a global table, such as coadd_objects? I think when there is no dot in the table name, the owner clause should not be present at all

Reply to this email directly or view it on GitHub.

@esheldon
Copy link
Owner

by global table I just mean it is visible in the global namespace. You are right that it does have an owner, but has just been made more visible.

@joezuntz
Copy link
Contributor Author

Okay. So who owns the table (or whatever it is) called COADD_OBJECTS? I can’t see it listed anywhere.

Joe

On 30 Oct 2014, at 14:22, Erin Sheldon [email protected] wrote:

by global table I just mean it is visible in the global namespace. You are right that it does have an owner, but has just been made more visible.


Reply to this email directly or view it on GitHub.

@esheldon
Copy link
Owner

I have no idea!

@joezuntz
Copy link
Contributor Author

I've concluded I don't really understand Oracle on any level. Better leave this PR alone for now.

@esheldon
Copy link
Owner

I agree about oracle. I find it very opaque and the documentation hard to find, follow.

It might be a good idea to just ask Todd how he would do it.

@joezuntz
Copy link
Contributor Author

Yeah. I've decided to avoid asking the DM people too many questions until after the Y1 release, though. This can wait until then!.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants